CWE
Home > CWE List > CWE- Individual Dictionary Definition (1.1)  
Search by ID:

CWE-616: Incomplete Identification of Uploaded File Variables (PHP)

Individual Definition in a New Window
Incomplete Identification of Uploaded File Variables (PHP)
Status: Incomplete
Weakness ID: 616 (Weakness Variant)
Description
Summary

The PHP application uses an old method for processing uploaded files by referencing the four global variables that are set for each file (e.g. $varname, $varname_size, $varname_name, $varname_type). These variables could be overwritten by attackers, causing the application to process unauthorized files.

Extended Description

These global variables could be overwritten by POST requests, cookies, or other methods of populating or overwriting these variables This could be used to read or process arbitrary files by providing values such as "/etc/passwd".

Weakness Ordinalities
Primary (where the weakness exists independent of other weaknesses)
Potential Mitigations
Architecture and Design

Use PHP 4 or later.

Architecture and Design

If you must support older PHP versions, write your own version of is_uploaded_file() and run it against $HTTP_POST_FILES['userfile']))

For later PHP versions, reference uploaded files using the $HTTP_POST_FILES or $_FILES variables, and use is_uploaded_file() or move_uploaded_file() to ensure that you are dealing with an uploaded file.

Demonstrative Examples
Example 1:

As of 2006, the "four globals" method is probably in sharp decline, but older PHP applications could have this issue.

In the "four globals" method, PHP sets the following 4 global variables (where "varname" is application-dependent):

PHP Example:
$varname = name of the temporary file on local machine
$varname_size = size of file
$varname_name = original name of file provided by client
$varname_type = MIME type of the file
Example 2:

"The global $_FILES exists as of PHP 4.1.0 (Use $HTTP_POST_FILES instead if using an earlier version). These arrays will contain all the uploaded file information."

PHP Example:
$_FILES['userfile']['name'] - original filename from client
$_FILES['userfile']['tmp_name'] - the temp filename of the file on the server

** note: 'userfile' is the field name from the web form; this can vary.

Observed Examples
ReferenceDescription
program does not distinguish between normal $_POST variables and the ones that are used for recognizing that a file has been downloaded.
PHP web forum does not properly verify whether a file was uploaded, allowing attackers to reference other files by modifying POST variables.
product doesn't check if the variables for an upload were set by uploading the file, or other methods such as $_POST.
product does not distinguish uploaded file from other files.
PHP script does not restrict access to uploaded files. Overlaps container error.
Other Notes
References
Shaun Clowes. "A Study in Scarlet - section 5, "File Upload"".
Relationships
NatureTypeIDNameView(s) this relationship pertains toView(s)
ChildOfCategoryCategory429Handler Errors
Development Concepts (primary)699
ChildOfWeakness ClassWeakness ClassWeakness Class345Insufficient Verification of Data Authenticity
Research Concepts (primary)1000
PeerOfWeakness VariantWeakness VariantWeakness Variant473PHP External Variable Modification
Research Concepts1000
Taxonomy Mappings
Mapped Taxonomy NameMapped Node Name
PLOVERIncomplete Identification of Uploaded File Variables (PHP)
Applicable Platforms
Languages
PHP
Time of Introduction
* Implementation
Content History
Submissions
PLOVER. (Externally Mined)
Modifications
Eric Dalci. Cigital. 2008-07-01. (External)
updated Time_of_Introduction
CWE Content Team. MITRE. 2008-09-08. (Internal)
updated Relationships, Observed_Example, Other_Notes, Taxonomy_Mappings, Weakness_Ordinalities
CWE Content Team. MITRE. 2008-10-14. (Internal)
updated Description, Other_Notes, Potential_Mitigations
Page Last Updated: November 24, 2008