The application uses multiple validation forms with the same name, which might cause the Struts Validator to validate a form that the programmer does not expect.
Extended Description
If two validation forms have the same name, the Struts Validator arbitrarily chooses one of the forms to use for input validation and discards the other. This decision might not correspond to the programmer's expectations, possibly leading to resultant weaknesses. Moreover, it indicates that the validation logic is not up-to-date, and can indicate that other, more subtle validation errors are present.
Time of Introduction
Implementation
Applicable Platforms
Languages
Java
Common Consequences
Scope
Effect
Integrity
Technical Impact: Unexpected state
Demonstrative Examples
Example 1
Two validation forms with the same name.
(Bad Code)
Example
Language: XML
<form-validation>
<formset>
<form name="ProjectForm"> ...
</form>
<form name="ProjectForm"> ...
</form>
</formset>
</form-validation>
It is critically important that validation logic be maintained and
kept in sync with the rest of the application.
Potential Mitigations
Phase: Implementation
The DTD or schema validation will not catch the duplicate occurrence
of the same form name. To find the issue in the implementation, manual
checks or automated static analysis could be applied to the xml
configuration files.
Weakness Ordinalities
Ordinality
Description
Primary
(where
the weakness exists independent of other weaknesses)
Description
