 |
 
|
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
CWE-105: Struts: Form Field Without Validator
 DescriptionDescription Summary The application has a form field that is not validated by a corresponding validation form, which can introduce other weaknesses related to insufficient input validation.
Time of Introduction
Applicable PlatformsLanguages Java Common Consequences
Demonstrative ExamplesExample 1 In the following example the Java class RegistrationForm is a Struts framework ActionForm Bean that will maintain user input data from a registration webpage for an online business site. The user will enter registration data and, through the Struts framework, the RegistrationForm bean will maintain the user data in the form fields using the private member variables. The RegistrationForm class uses the Struts validation capability by extending the ValidatorForm class and including the validation for the form fields within the validator XML file, validator.xml. (Good Code) public class RegistrationForm extends
org.apache.struts.validator.ValidatorForm { // private variables for registration form
private String name;
private String address;
private String city;
private String state;
private String zipcode;
private String phone;
private String email;
public RegistrationForm() {
super();
}
// getter and setter methods for private
variables
...
} The validator XML file, validator.xml, provides the validation for the form fields of the RegistrationForm. (Bad Code) Example
Language: XML <form-validation> <formset>
<form name="RegistrationForm">
<field property="name"
depends="required">
<arg position="0"
key="prompt.name"/>
</field>
<field property="address"
depends="required">
<arg position="0"
key="prompt.address"/>
</field>
<field property="city"
depends="required">
<arg position="0"
key="prompt.city"/>
</field>
<field property="state"
depends="required,mask">
<arg position="0"
key="prompt.state"/>
<var>
<var-name>mask</var-name>
<var-value>[a-zA-Z]{2}</var-value>
</var>
</field>
<field property="zipcode"
depends="required,mask">
<arg position="0"
key="prompt.zipcode"/>
<var>
<var-name>mask</var-name>
<var-value>\d{5}</var-value>
</var>
</field>
</form>
</formset>
</form-validation> However, in the previous example the validator XML file, validator.xml, does not provide validators for all of the form fields in the RegistrationForm. Validator forms are only provided for the first five of the seven form fields. The validator XML file should contain validator forms for all of the form fields for a Struts ActionForm bean. The following validator.xml file for the RegistrationForm class contains validator forms for all of the form fields. (Good Code) Example
Language: XML <form-validation> <formset>
<form name="RegistrationForm">
<field property="name"
depends="required">
<arg position="0"
key="prompt.name"/>
</field>
<field property="address"
depends="required">
<arg position="0"
key="prompt.address"/>
</field>
<field property="city"
depends="required">
<arg position="0"
key="prompt.city"/>
</field>
<field property="state"
depends="required,mask">
<arg position="0"
key="prompt.state"/>
<var>
<var-name>mask</var-name>
<var-value>[a-zA-Z]{2}</var-value>
</var>
</field>
<field property="zipcode"
depends="required,mask">
<arg position="0"
key="prompt.zipcode"/>
<var>
<var-name>mask</var-name>
<var-value>\d{5}</var-value>
</var>
</field>
<field property="phone"
depends="required,mask">
<arg position="0"
key="prompt.phone"/>
<var>
<var-name>mask</var-name>
<var-value>^([0-9]{3})(-)([0-9]{4}|[0-9]{4})$</var-value>
</var>
</field>
<field property="email"
depends="required,email">
<arg position="0"
key="prompt.email"/>
</field>
</form>
</formset>
</form-validation> Potential Mitigations
Other Notes
Weakness Ordinalities
Relationships
Causal NatureExplicit Taxonomy Mappings
Content History
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Page Last Updated:
February 20, 2013
|
|
CWE is co-sponsored by the office of Cybersecurity and Communications at the U.S. Department of Homeland Security. This Web site is sponsored and managed by The MITRE Corporation to enable stakeholder collaboration. Copyright © 2006-2013, The MITRE Corporation. CWE, CWSS, CWRAF, and the CWE logo are trademarks of The MITRE Corporation. Contact cwe@mitre.org for more information. |
|
|
