|
|
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
CWE-107: Struts: Unused Validation Form
 DescriptionDescription Summary An unused validation form indicates that validation logic is not up-to-date.
Extended Description It is easy for developers to forget to update validation logic when they remove or rename action form mappings. One indication that validation logic is not being properly maintained is the presence of an unused validation form. Time of Introduction
Applicable PlatformsLanguages Java Common Consequences
Demonstrative ExamplesExample 1 In the following example the class RegistrationForm is a Struts framework ActionForm Bean that will maintain user input data from a registration webpage for an online business site. The user will enter registration data and, through the Struts framework, the RegistrationForm bean will maintain the user data in the form fields using the private member variables. The RegistrationForm class uses the Struts validation capability by extending the ValidatorForm class and including the validation for the form fields within the validator XML file, validator.xml. (Bad Code) Example
Language: Java public class RegistrationForm extends
org.apache.struts.validator.ValidatorForm { // private variables for registration form
private String name;
private String address;
private String city;
private String state;
private String zipcode;
// no longer using the phone form field
// private String phone;
private String email;
public RegistrationForm() {
super();
}
// getter and setter methods for private
variables
...
} (Bad Code) Example
Language: XML <form-validation> <formset>
<form name="RegistrationForm">
<field property="name"
depends="required">
<arg position="0"
key="prompt.name"/>
</field>
<field property="address"
depends="required">
<arg position="0"
key="prompt.address"/>
</field>
<field property="city"
depends="required">
<arg position="0"
key="prompt.city"/>
</field>
<field property="state"
depends="required,mask">
<arg position="0"
key="prompt.state"/>
<var>
<var-name>mask</var-name>
<var-value>[a-zA-Z]{2}</var-value>
</var>
</field>
<field property="zipcode"
depends="required,mask">
<arg position="0"
key="prompt.zipcode"/>
<var>
<var-name>mask</var-name>
<var-value>\d{5}</var-value>
</var>
</field>
<field property="phone"
depends="required,mask">
<arg position="0"
key="prompt.phone"/>
<var>
<var-name>mask</var-name>
<var-value>^([0-9]{3})(-)([0-9]{4}|[0-9]{4})$</var-value>
</var>
</field>
<field property="email"
depends="required,email">
<arg position="0"
key="prompt.email"/>
</field>
</form>
</formset>
</form-validation> However, the validator XML file, validator.xml, for the RegistrationForm class includes the validation form for the user input form field "phone" that is no longer used by the input form and the RegistrationForm class. Any validation forms that are no longer required should be removed from the validator XML file, validator.xml. The existence of unused forms may be an indication to attackers that this code is out of date or poorly maintained. Potential Mitigations
Weakness Ordinalities
Relationships
Causal NatureExplicit Taxonomy Mappings
Content History
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Page Last Updated:
February 20, 2013
|
|
CWE is co-sponsored by the office of Cybersecurity and Communications at the U.S. Department of Homeland Security. This Web site is sponsored and managed by The MITRE Corporation to enable stakeholder collaboration. Copyright © 2006-2013, The MITRE Corporation. CWE, CWSS, CWRAF, and the CWE logo are trademarks of The MITRE Corporation. Contact cwe@mitre.org for more information. |
|
|