CWE-147: Improper Neutralization of Input Terminators
Improper Neutralization of Input Terminators
Weakness ID: 147 (Weakness Variant)
Status: Draft
Description
Description Summary
The software receives input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could be interpreted as input terminators when they are sent to a downstream component.
Extended Description
For example, a "." in SMTP signifies the end of mail message data, whereas a null character can be used for the end of a string.
MFV. mail server does not properly identify
terminator string to signify end of message, causing corruption, possibly in
conjunction with off-by-one error.
MFV. mail server does not properly identify
terminator string to signify end of message, causing corruption, possibly in
conjunction with off-by-one error.
Improperly terminated comment or phrase allows
commands.
Potential Mitigations
Developers should anticipate that terminators will be
injected/removed/manipulated in the input vectors of their software
system. Use an appropriate combination of black lists and white lists to
ensure only valid, expected and appropriate input is processed by the
system.
Phase: Implementation
Strategy: Input Validation
Assume all input is malicious. Use an "accept known good" input
validation strategy, i.e., use a whitelist of acceptable inputs that
strictly conform to specifications. Reject any input that does not
strictly conform to specifications, or transform it into something that
does.
When performing input validation, consider all potentially relevant
properties, including length, type of input, the full range of
acceptable values, missing or extra inputs, syntax, consistency across
related fields, and conformance to business rules. As an example of
business rule logic, "boat" may be syntactically valid because it only
contains alphanumeric characters, but it is not valid if the input is
only expected to contain colors such as "red" or "blue."
Do not rely exclusively on looking for malicious or malformed inputs
(i.e., do not rely on a blacklist). A blacklist is likely to miss at
least one undesirable input, especially if the code's environment
changes. This can give attackers enough room to bypass the intended
validation. However, blacklists can be useful for detecting potential
attacks or determining which inputs are so malformed that they should be
rejected outright.
Use and specify a strong output encoding (such as ISO 8859-1 or UTF
8).
Phase: Implementation
Strategy: Input Validation
Inputs should be decoded and canonicalized to the application's current internal representation before being validated (CWE-180). Make sure that the application does not decode the same input twice (CWE-174). Such errors could be used to bypass whitelist validation schemes by introducing dangerous inputs after they have been checked.