CWE-96: Improper Neutralization of Directives in Statically Saved Code ('Static Code Injection')
Improper Neutralization of Directives in Statically Saved Code ('Static Code Injection')
Weakness ID: 96 (Weakness Base)
Status: Draft
Description
Description Summary
The software receives input from an upstream component, but it does not neutralize or incorrectly neutralizes code syntax before inserting the input into an executable resource, such as a library, configuration file, or template.
Time of Introduction
Architecture and Design
Implementation
Applicable Platforms
Languages
PHP
Perl
All Interpreted Languages
Common Consequences
Scope
Effect
Confidentiality
Technical Impact: Read files or
directories; Read application
data
The injected code could access restricted data / files.
Access Control
Technical Impact: Bypass protection
mechanism
In some cases, injectable code controls authentication; this may lead
to a remote vulnerability.
Access Control
Technical Impact: Gain privileges / assume
identity
Injected code can access resources that the attacker is directly
prevented from accessing.
Integrity
Confidentiality
Availability
Other
Technical Impact: Execute unauthorized code or
commands
Code injection attacks can lead to loss of data integrity in nearly
all cases as the control-plane data injected is always incidental to
data recall or writing. Additionally, code injection can often result in
the execution of arbitrary code.
Non-Repudiation
Technical Impact: Hide activities
Often the actions performed by injected control code are
unlogged.
Demonstrative Examples
Example 1
This example attempts to write user messages to a message file and
allow users to view them.
While the programmer intends for the MessageFile to only include data,
an attacker can provide a message such as:
(Attack)
name=h4x0r
message=%3C?php%20system(%22/bin/ls%20-l%22);?%3E
which will decode to the following:
(Attack)
<?php system("/bin/ls -l");?>
The programmer thought they were just including the contents of a
regular data file, but PHP parsed it and executed the code. Now, this
code is executed any time people view messages.
Notice that XSS (CWE-79) is also possible in this situation.
chain: execution after redirect allows
non-administrator to perform static code
injection.
Potential Mitigations
Phase: Implementation
Strategy: Input Validation
Assume all input is malicious. Use an "accept known good" input
validation strategy, i.e., use a whitelist of acceptable inputs that
strictly conform to specifications. Reject any input that does not
strictly conform to specifications, or transform it into something that
does.
When performing input validation, consider all potentially relevant
properties, including length, type of input, the full range of
acceptable values, missing or extra inputs, syntax, consistency across
related fields, and conformance to business rules. As an example of
business rule logic, "boat" may be syntactically valid because it only
contains alphanumeric characters, but it is not valid if the input is
only expected to contain colors such as "red" or "blue."
Do not rely exclusively on looking for malicious or malformed inputs
(i.e., do not rely on a blacklist). A blacklist is likely to miss at
least one undesirable input, especially if the code's environment
changes. This can give attackers enough room to bypass the intended
validation. However, blacklists can be useful for detecting potential
attacks or determining which inputs are so malformed that they should be
rejected outright.
Phase: Implementation
Strategy: Output Encoding
Perform proper output validation and escaping to neutralize all code
syntax from data written to code files.
Other Notes
"HTML injection" (see XSS) could be thought of as an example of this, but
it is executed on the client side, not the server side. Server-Side Includes
(SSI) are an example of direct static code injection.
This issue is most frequently found in PHP applications that allow users
to set configuration variables that are stored within executable php files.
Technically, this could also be performed in some compiled code (e.g. by
byte-patching an executable), although it is highly unlikely.
Weakness Ordinalities
Ordinality
Description
Primary
(where
the weakness exists independent of other weaknesses)