CWE

Common Weakness Enumeration

A Community-Developed List of Software Weakness Types

CWE/SANS Top 25 Most Dangerous Software Errors
Home > CWE List > CWE- Individual Dictionary Definition (2.11)  
ID

CWE-831: Signal Handler Function Associated with Multiple Signals

Weakness ID: 831
Abstraction: Base
Status: Incomplete
Presentation Filter:
+ Description

Description Summary

The software defines a function that is used as a handler for more than one signal.

Extended Description

While sometimes intentional and safe, when the same function is used to handle multiple signals, a race condition could occur if the function uses any state outside of its local declaration, such as global variables or non-reentrant functions, or has any side effects.

An attacker could send one signal that invokes the handler function; in many OSes, this will typically prevent the same signal from invoking the handler again, at least until the handler function has completed execution. However, the attacker could then send a different signal that is associated with the same handler function. This could interrupt the original handler function while it is still executing. If there is shared state, then the state could be corrupted. This can lead to a variety of potential consequences depending on context, including denial of service and code execution.

Another rarely-explored possibility arises when the signal handler is only designed to be executed once (if at all). By sending multiple signals, an attacker could invoke the function more than once. This may generate extra, unintended side effects. A race condition might not even be necessary; the attacker could send one signal, wait until it is handled, then send the other signal.

+ Common Consequences
ScopeEffect
Availability
Integrity
Confidentiality
Access Control
Other

Technical Impact: DoS: crash / exit / restart; Execute unauthorized code or commands; Read application data; Gain privileges / assume identity; Bypass protection mechanism; Varies by context

The most common consequence will be a corruption of the state of the software, possibly leading to a crash or exit. However, if the signal handler is operating on state variables for security relevant libraries or protection mechanisms, the consequences can be far more severe, including protection mechanism bypass, privilege escalation, or information exposure.

+ Demonstrative Examples

Example 1

This code registers the same signal handler function with two different signals.

(Bad Code)
 
void handler (int sigNum) {
...
}
int main (int argc, char* argv[]) {
signal(SIGUSR1, handler)
signal(SIGUSR2, handler)
}

Example 2

This code registers the same signal handler function with two different signals (CWE-831). If those signals are sent to the process, the handler creates a log message (specified in the first argument to the program) and exits.

(Bad Code)
 
char *logMessage;

void handler (int sigNum) {
syslog(LOG_NOTICE, "%s\n", logMessage);
free(logMessage);
/* artificially increase the size of the timing window to make demonstration of this weakness easier. */
sleep(10);
exit(0);
}

int main (int argc, char* argv[]) {
logMessage = strdup(argv[1]);
/* Register signal handlers. */
signal(SIGHUP, handler);
signal(SIGTERM, handler);
/* artificially increase the size of the timing window to make demonstration of this weakness easier. */
sleep(10);
}

The handler function uses global state (globalVar and logMessage), and it can be called by both the SIGHUP and SIGTERM signals. An attack scenario might follow these lines:

  • The program begins execution, initializes logMessage, and registers the signal handlers for SIGHUP and SIGTERM.

  • The program begins its "normal" functionality, which is simplified as sleep(), but could be any functionality that consumes some time.

  • The attacker sends SIGHUP, which invokes handler (call this "SIGHUP-handler").

  • SIGHUP-handler begins to execute, calling syslog().

  • syslog() calls malloc(), which is non-reentrant. malloc() begins to modify metadata to manage the heap.

  • The attacker then sends SIGTERM.

  • SIGHUP-handler is interrupted, but syslog's malloc call is still executing and has not finished modifying its metadata.

  • The SIGTERM handler is invoked.

  • SIGTERM-handler records the log message using syslog(), then frees the logMessage variable.

At this point, the state of the heap is uncertain, because malloc is still modifying the metadata for the heap; the metadata might be in an inconsistent state. The SIGTERM-handler call to free() is assuming that the metadata is inconsistent, possibly causing it to write data to the wrong location while managing the heap. The result is memory corruption, which could lead to a crash or even code execution, depending on the circumstances under which the code is running.

Note that this is an adaptation of a classic example as originally presented by Michal Zalewski [R.831.1]; the original example was shown to be exploitable for code execution.

Also note that the strdup(argv[1]) call contains a potential buffer over-read (CWE-126) if the program is called without any arguments, because argc would be 0, and argv[1] would point outside the bounds of the array.

+ Relationships
NatureTypeIDNameView(s) this relationship pertains toView(s)
ChildOfWeakness BaseWeakness Base364Signal Handler Race Condition
Development Concepts (primary)699
Research Concepts (primary)1000
+ References
[R.831.1] [REF-53] Michal Zalewski. "Delivering Signals for Fun and Profit". <http://lcamtuf.coredump.cx/signals.txt>.
[R.831.2] [REF-54] "Race Condition: Signal Handling". <http://www.fortify.com/vulncat/en/vulncat/cpp/race_condition_signal_handling.html>.
+ Content History
Submissions
Submission DateSubmitterOrganizationSource
2010-12-12MITREInternal CWE Team
Modifications
Modification DateModifierOrganizationSource
2011-06-01CWE Content TeamMITREInternal
updated Common_Consequences
2011-06-27CWE Content TeamMITREInternal
updated Common_Consequences
2014-06-23CWE Content TeamMITREInternal
updated Demonstrative_Examples, References

More information is available — Please select a different filter.
Page Last Updated: May 05, 2017